Correctly return electra attestations for block getter #13993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
reviewed
May 13, 2024
| @@ -1116,7 +1116,7 @@ func (b *BeaconBlockBody) Attestations() []interfaces.Attestation { | |||
| return nil | |||
| } | |||
| atts = make([]interfaces.Attestation, len(b.attestationsElectra)) | |||
| for i, a := range b.attestations { | |||
| for i, a := range b.attestationsElectra { | |||
james-prysm
approved these changes
May 13, 2024
terencechain
force-pushed
the
fix-attestations-getter
branch
from
c5d9517 to
e09bc05
Compare
ErnestK
pushed a commit
to ErnestK/prysm
that referenced
this pull request
May 19, 2024
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block getter
Attestations()returns non-Electra attestations even if the block version is Electra. This PR ensures the correct version of attestation is returned with a unit test.