Backfill throttling #13855
Merged
Backfill throttling #13855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
approved these changes
Apr 9, 2024
nisdas
pushed a commit
that referenced
this pull request
Jul 4, 2024
* add a sleep between retries as a simple throttle * unit test * deepsource --------- Co-authored-by: Kasey Kirkham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
If backfill gets wedged (for instance what happened with the finalized index bug we fixed in the last release) it can retry the latest batch in a hot loop. I'm worried that if there is some backfill bug or network condition that causes a batch to continually fail, this could spam peers with requests and create a lot of log volume.
So this PR adds a delay of 1 second before retrying a failed batch. This is a blunt tool to quickly make the current situation a bit safer before we update backfill to share rate limiting functionality with init sync.