validator client on rest mode has an inappropriate context deadline for events #13771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
added
Bug
api/client/event/event_stream.go
Outdated
Comment on lines
109
to
112
| for { | ||
| if ok := scanner.Scan(); !ok { | ||
| break | ||
| } |
There was a problem hiding this comment.
Is this change necessary?
There was a problem hiding this comment.
i don't think so anymore I think I'll revert this
Co-authored-by: Preston Van Loon <[email protected]>
Co-authored-by: Preston Van Loon <[email protected]>
…perfluous response.WriteHeader error
prestonvanloon
approved these changes
Mar 20, 2024
rkapka
previously approved these changes
Mar 20, 2024
rkapka
approved these changes
Mar 20, 2024
nalepae
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fixes the following error on the validator client while running with the flag
--enable-beacon-rest-apiFixes the following issue to bubble up errors and kill the connection instead of just logging errors continuously
Which issues(s) does this PR fix?
Fixes #13763
Other notes for review