fix 1-worker underflow; lower default batch size #13734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Mar 13, 2024
| @@ -79,6 +79,10 @@ func (c *batchSequencer) update(b batch) { | |||
| // so we want to copy c to a, then on i=3, d to b, then on i=4 e to c. | |||
| c.seq[i-done] = c.seq[i] | |||
| } | |||
| if done == 1 && len(c.seq) == 1 { | |||
There was a problem hiding this comment.
is it possible to test for this ?
nisdas
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
Other
What does this PR do? Why is it needed?
This PR fixes a panic that occurs soon after the first backfill batch completes, if the backfill worker count flag is set to 1 (
--backfill-worker-count=1).Also, the default value for
--backfill-batch-sizeis lowered from 64 to 32, based on testing in mainnet where it was observed that this value led to a healthier mix of peer implementations, due to the higher batch size triggering rate limits more frequently for some peer implementations.