Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Eth-Consensus-Version header to SubmitBlindedBlock #12029

Merged
merged 4 commits into from
Feb 22, 2023

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Feb 22, 2023

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Implements ethereum/builder-specs@e570404 (#60)

@rkapka rkapka added Ready For Review A pull request ready for code review Builder PR or issue that supports builder related work labels Feb 22, 2023
@rkapka rkapka requested a review from a team as a code owner February 22, 2023 12:13
@@ -342,29 +347,6 @@ func (c *Client) SubmitBlindedBlock(ctx context.Context, sb interfaces.ReadOnlyS
}
}

// SubmitBlindedBlockCapella calls the builder API endpoint that binds the validator to the builder and submits the block.
// The response is the full ExecutionPayloadCapella used to create the blinded block.
func (c *Client) SubmitBlindedBlockCapella(ctx context.Context, sb *ethpb.SignedBlindedBeaconBlockCapella) (*v1.ExecutionPayloadCapella, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct that we are removing this?

Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prylabs-bulldozer prylabs-bulldozer bot merged commit 29f645f into develop Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the builder-header branch February 22, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builder PR or issue that supports builder related work Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants