Prysm V4 - Deprecate web UI endpoints #12025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
previously approved these changes
Feb 22, 2023
| @@ -14,140 +14,175 @@ option java_outer_classname = "WebProto"; | |||
| option java_package = "org.ethereum.validator.accounts.v2"; | |||
| option php_namespace = "Ethereum\\Validator\\Accounts\\V2"; | |||
|
|
|||
| // DEPRECATED: Prysm Web UI and associated endpoints will be fully removed in a future hard fork. | |||
There was a problem hiding this comment.
Same feedback here about putting the deprecation notice at the end of the comment block to be consistent with the go style of deprecation. I don't feel strongly about this so I won't mark up this file with the code change suggestions.
terencechain
approved these changes
Feb 23, 2023
rauljordan
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
deprecation
What does this PR do? Why is it needed?
This PR starts marking web UI endpoints for deprecation and full removal at a later hard fork.
Which issues(s) does this PR fix?
Relates to #11841
document prysmaticlabs/documentation#720