Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Failing E2E Runs #11993

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix Failing E2E Runs #11993

merged 3 commits into from
Feb 17, 2023

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Feb 15, 2023

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Fixes withdrawal evaluator to handle edge cases with sync committee members better.
  • Skip the withdrawal evaluator for multiclient as lighthouse does not have the ability to configure
    its withdrawal sweep.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review OK to merge labels Feb 15, 2023
@nisdas nisdas requested a review from a team as a code owner February 15, 2023 13:08
@prylabs-bulldozer prylabs-bulldozer bot merged commit 7d7c91c into develop Feb 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the fixE2EBug branch February 17, 2023 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkapka rkapka rkapka approved these changes

@potuz potuz potuz approved these changes

@kasey kasey Awaiting requested review from kasey kasey was automatically assigned from prysmaticlabs/core-team

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan was automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain was automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nisdas @potuz @rkapka