Use correct attribute if there's a payload ID cache miss #11918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Jan 26, 2023
| if err != nil { | ||
| return nil, err | ||
| } | ||
| case version.Bellatrix: |
There was a problem hiding this comment.
Add a default case where we return an error for an unknown version.
nisdas
previously approved these changes
Jan 26, 2023
terencechain
added
Ready For Review
|
Blocking for @potuz |
potuz
added
OK to merge
and removed
Blocked
potuz
approved these changes
Jan 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before a validator proposes a block, the validator would update the head. If the head diffs from the previous head, the validator loses "the bet" and can no longer use the prev cached payload ID cache and will have to call fcu with payload attribute right before proposing. In this case, prysm has a bug that does not include the correct attribute with withdrawals