Add REST implementation for Validator's GetDuties
#11893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vignol/add-subscribe-committee-subnets-2
…vignol/add-subscribe-committee-subnets-2
…:prysmaticlabs/prysm into develop
…hub.com:PatriceVignola/prysm into develop
…vignol/add-get-duties
rkapka
requested changes
Jan 20, 2023
james-prysm
reviewed
Jan 20, 2023
| func (c beaconApiDutiesProvider) GetCommittees(ctx context.Context, epoch types.Epoch) ([]*apimiddleware.CommitteeJson, error) { | ||
| committeeParams := url.Values{} | ||
| committeeParams.Add("epoch", strconv.FormatUint(uint64(epoch), 10)) | ||
| committeesRequest := buildURL("/eth/v1/beacon/states/head/committees", committeeParams) |
There was a problem hiding this comment.
I want to double check if using the head in this case is correct, the grpc one read a little differently.
There was a problem hiding this comment.
The way I understand it from the spec, the epoch query parameter decides which epoch to query the committees for. The head committees will only be fetches if epoch isn't specified.
| epoch | Fetch committees for the given epoch. If not present then the committees for the epoch of the state will be obtained. |
|---|
There was a problem hiding this comment.
got it this makes sense.
PatriceVignola
requested review from
rkapka
and removed request for
saolyn,
potuz and
terencechain
james-prysm
approved these changes
Jan 24, 2023
rkapka
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
It adds the
GetDutiesREST API endpoint for the validator.