Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fail" in logs makes FAIL in e2e hard to find #11867

Merged
merged 2 commits into from
Jan 13, 2023
Merged

"Fail" in logs makes FAIL in e2e hard to find #11867

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cc0340
"Fail" in logs makes FAIL in e2e hard to find
kasey Jan 13, 2023
cf6eb1f
Merge branch 'develop' into failed-me-for-the-last-time
kasey Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion monitoring/tracing/tracer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func Setup(serviceName, processName, endpoint string, sampleFraction float64, en
},
BufferMaxCount: 10000,
OnError: func(err error) {
log.WithError(err).Error("Failed to process span")
log.WithError(err).Error("Could not process span")
},
})
if err != nil {
Expand Down