Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better reconstruct error msg while EL client is syncing #11851

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Better reconstruct error msg while EL client is syncing #11851

merged 2 commits into from
Jan 9, 2023

Conversation

terencechain
Copy link
Member

What type of PR is this?

Code health error improvement

What does this PR do? Why is it needed?

[2023-01-07 19:36:02] ERROR sync: Could not get reconstruct full bellatrix block from blinded body error=block hash field in execution header 0x21295832b07679e17f9c3e2ed8edafae28ac15deeac6cdcb8e0ddc68526c2b0d does not match execution block hash 0x0000000000000000000000000000000000000000000000000000000000000000 handler=beacon_blocks_by_root

👇🏼

[2023-01-08 08:44:36]  WARN sync: Could not reconstruct block from header with syncing execution client. Waiting to complete syncing error=Block hash is empty 0x0000... handler=beacon_blocks_by_root

Which issues(s) does this PR fix?

Fixes #

Other notes for review

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge labels Jan 8, 2023
@terencechain terencechain requested a review from a team as a code owner January 8, 2023 16:48
@terencechain terencechain self-assigned this Jan 8, 2023
@terencechain terencechain requested review from kasey, saolyn and potuz January 8, 2023 16:48
saolyn
saolyn approved these changes Jan 9, 2023
View reviewed changes
Copy link
Contributor

@saolyn saolyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prylabs-bulldozer prylabs-bulldozer bot merged commit bad7c6a into develop Jan 9, 2023
@delete-merged-branch delete-merged-branch bot deleted the better-reconstruct-msg branch January 9, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saolyn saolyn saolyn approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @saolyn