Prevent pollution between scenario tests #11850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a few e2e evaluators, package-level variables are used to persist data across evaluator calls, which are otherwise stateless. In the scenario test runs, where we execute multiple tests in the same bazel command, these variables are contaminated on all but the first test. I think we should redesign these evaluators with the understanding that some can't be stateless, but all need to reset between runs. This PR moves stateful values from package-level variables in the
evaluators
package, into theEvaluationContext
that is already passed to all evaluators, which is re-initialized between runs.What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This fixes a spurious test failure for the
TestEndToEnd_MinimalConfig_ValidatorRESTApi
target, specifically this evaluator: