Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proposer duties one epoch in advance part 2 #11818

Merged
merged 8 commits into from
Dec 22, 2022

Conversation

terencechain
Copy link
Member

@terencechain terencechain commented Dec 22, 2022

Mostly @rkapka's work. I just helped with clean up. Credit goes to him.

Built on top of #11817. This PR querying for proposer duties one epoch ahead of the current epoch

Fixes #10035

@terencechain terencechain added the Ready For Review A pull request ready for code review label Dec 22, 2022
@terencechain terencechain requested a review from a team as a code owner December 22, 2022 15:08
@prestonvanloon
Copy link
Member

Tests fail

@rkapka
Copy link
Contributor

rkapka commented Dec 22, 2022

Tests fail because running all package tests returns different indexes than when running a single test. This is very annoying and should be fixed at some point.

@rkapka rkapka merged commit dac555a into develop Dec 22, 2022
@rkapka rkapka deleted the proposer-epoch-in-advance-1 branch December 22, 2022 22:00
@rkapka
Copy link
Contributor

rkapka commented Dec 22, 2022

Approving and merging because @potuz gave a "LGTM" on Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REST API - Can't Look Ahead at Upcoming Block Proposals
3 participants