E2E from Phase0 or Bellatrix #11802
Merged
E2E from Phase0 or Bellatrix #11802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Dec 21, 2022
| @@ -197,7 +197,26 @@ func (node *BeaconNode) generateGenesis(ctx context.Context) (state.BeaconState, | |||
| DepositCount: 0, | |||
| BlockHash: gb.Hash().Bytes(), | |||
| } | |||
| v := e2etypes.GenesisFork() | |||
| switch v { | |||
| case version.Bellatrix: | |||
james-prysm
reviewed
Dec 21, 2022
| account = common.BytesToAddress(fr) | ||
| // If the beacon chain has transitioned to Bellatrix, but the EL hasn't hit TTD, we could see a few slots | ||
| // of blocks with empty payloads. | ||
| if bytes.Equal(fr.Block.Body.ExecutionPayload.BlockHash, make([]byte, 32)) { |
nisdas
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
PR #11746 changed e2e to start from bellatrix, allowing faster testnet startup by skipping earlier forks and removing the need to create on chain deposits so that deposit events would be seen by the deposit tracker. However that PR hardcoded starting up from bellatrix and broke starting from phase0. This PR fixes that problem and allows e2e to start from phase0, and changes phase0 to be the default starting point.
Which issues(s) does this PR fix?
Fixes #11750
Other notes for review
The method to create the pre-mined BeaconState is a mess of copy/pasta, and there are some other things I want to clean up. I'm going to work on refactoring that code, but I also want to merge this ASAP, so I'm putting it up in its current form. I'm hoping to get things cleaned up before someone reviews but we can also do that cleanup in a follow-up PR in the interest of starting e2e from phase0 and un-breaking scenario tests asap.
Shout-out to @nisdas for help debugging how too low of a TTD value was impacting the e2e run.
NB: we are going to merge this without altair support, follow up PR to refactor premined genesis codepaths with altair support coming next.