EIP-4881: Spec implementation #11720
Conversation
| }, nil | ||
| } | ||
|
|
||
| func (d *DepositTree) finalize(eth1data eth.Eth1Data, executionBlockHeight uint64) { |
There was a problem hiding this comment.
@prestonvanloon which Eth1Data should I be using here?
There was a problem hiding this comment.
That one seems correct. What other eth1data is there?
There was a problem hiding this comment.
I used eth "github.com/prysmaticlabs/prysm/v3/proto/eth/v1" since it made more sense to me but there is also eth "github.com/prysmaticlabs/prysm/v3/proto/prysm/v1alpha1" so wanted to double check.
There was a problem hiding this comment.
Ah -- Those are essentially the same thing. We had to duplicate it for some compatibility reasons with ssz-gen tooling
| depositCount: leftSubtree, | ||
| hash: finalized[0], | ||
| } | ||
| node.right = fromSnapshotParts(finalized[1:], deposits-leftSubtree, level-1) |
There was a problem hiding this comment.
check if you can do deposits-leftSubtree
| } | ||
|
|
||
| // Finalize marks deposits of the Merkle tree as finalized. | ||
| func (n *InnerNode) Finalize(depositsToFinalize uint64, depth uint64) MerkleTreeNode { |
There was a problem hiding this comment.
Checks on depth here to prevent underflow
| // PushLeaf adds a new leaf node at the next available zero node. | ||
| func (n *InnerNode) PushLeaf(leaf [32]byte, depth uint64) (MerkleTreeNode, error) { | ||
| if !n.left.IsFull() { | ||
| left, err := n.left.PushLeaf(leaf, depth-1) |
|
|
||
| // GetRoot returns the root of the Merkle tree. | ||
| func (z *ZeroNode) GetRoot() [32]byte { | ||
| if z.depth == DepositContractDepth { |
| //nolint:unused | ||
| func (d *DepositTree) pushLeaf(leaf [32]byte) error { | ||
| var err error | ||
| d.mixInLength++ |
There was a problem hiding this comment.
should we add after we push? or do so inside of push leaf? worried that if it fails, we would have still modified the tree
There was a problem hiding this comment.
It doesn't look like we need it for PushLeaf so I do not see a problem moving it below the error handling. We will most likely need to test it to be sure.
saolyn
force-pushed
the
eip4881-spec-implementation
branch
from
769055e to
6e2cb33
Compare
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Rewrite of the Go implementation for an optimized deposit tree as specified in eip-4881.
Which issues(s) does this PR fix?
Part of #11256
Other notes for review