Onboard validator's Beacon REST API usage to e2e tests #11704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riceVignola/prysm into user/pavignol/add-rest-api-e2e-tests
…vignol/add-rest-api-e2e-tests
nisdas
requested changes
Dec 6, 2022
There was a problem hiding this comment.
There is a misunderstanding on how grpc is used in our evaluators. All these evaluators query the beacon-node not the validator . So there is no need to change the format of the connection to validatorHelpers.NodeConnection . The evaluators will still work as expected because they query the beacon node, and whether the validator is running via grpc or the beacon rest-api makes no difference to this.
…vignol/add-rest-api-e2e-tests
PatriceVignola
requested review from
nisdas
and removed request for
terencechain and
james-prysm
…vignol/add-rest-api-e2e-tests
nisdas
reviewed
Dec 7, 2022
nisdas
previously approved these changes
Dec 8, 2022
…vignol/add-rest-api-e2e-tests
rkapka
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
It onboards the validator's Beacon REST API usage to the e2e tests by going through the following steps:
use_beacon_apibuildtime flag to a--enable-beacon-rest-apiflagvalidatorHelpers.NodeConnectionas an argument instead of a*grpc.ClientConn. There's unfortunately not a clean way to do this without touching a bunch of files, but the change is actually simple andvalidatorHelpers.NodeConnectionis simply a wrapper around*grpc.ClientConn. The behavior of existing e2e tests will not change.--enable-beacon-rest-apiflag.