Spec test: capella and update to v1.3.0-alpha.1
#11683
Conversation
| WithdrawalQueueLimit = 1099511627776 // WithdrawalQueueLimit defines the maximum number of withdrawals queued in the state. | ||
| ExecutionAddressLength = 20 // ExecutionAddressLength defines the length of an execution layer address. |
There was a problem hiding this comment.
They are not used, and they will never be used, so removed unused variables
| MaxWithdrawalsPerPayload = 16 // MaxWithdrawalsPerPayloadLength defines the maximum number of withdrawals that can be included in a payload. | ||
| WithdrawalQueueLimit = 1099511627776 // WithdrawalQueueLimit defines the maximum number of withdrawals queued in the state. | ||
| MaxWithdrawalsPerPayload = 4 // MaxWithdrawalsPerPayloadLength defines the maximum number of withdrawals that can be included in a payload. |
There was a problem hiding this comment.
Same here, why these changes to presents?
There was a problem hiding this comment.
The correct value for MaxWithdrawalsPerPayload is 4
This has to be fixed or else the minimal spec test will fail
| "slashings_reset_test.go", | ||
| "slashings_test.go", | ||
| ], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
There are no yaml files here that would match that glob.
| size = "medium", | ||
| timeout = "short", | ||
| srcs = ["finality_test.go"], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
Same here, there are no local yaml files that would match this glob
| data = glob(["*.yaml"]) + [ | ||
| "@consensus_spec_tests_mainnet//:test_data", | ||
| ], | ||
| shard_count = 4, |
There was a problem hiding this comment.
is this shard count appropriate? This looks like 1 test only.
| shard_count = 4, | |
| shard_count = 1, |
There was a problem hiding this comment.
+1 here, we're using 1 on devnets but I wasn't aware it was 1 for mainnet
| size = "enormous", | ||
| timeout = "short", | ||
| srcs = ["forkchoice_test.go"], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
| "voluntary_exit_test.go", | ||
| "withdrawals_test.go", | ||
| ], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
| name = "go_default_test", | ||
| size = "small", | ||
| srcs = ["rewards_test.go"], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
| "blocks_test.go", | ||
| "slots_test.go", | ||
| ], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
| name = "go_default_test", | ||
| size = "small", | ||
| srcs = ["ssz_static_test.go"], | ||
| data = glob(["*.yaml"]) + [ |
There was a problem hiding this comment.
| data = glob(["*.yaml"]) + [ | |
| data = [ |
| _, ok := data.Proto().(*enginev1.ExecutionPayloadCapella) | ||
| if ok { | ||
| return false, nil | ||
| } |
There was a problem hiding this comment.
This was a bad check. data is an interface, and the underlying object could be bellatrix or capella
| require.NoError(t, err) | ||
| require.Equal(t, true, got) | ||
| require.Equal(t, false, got) |
There was a problem hiding this comment.
Why is a Capella block not an execution block?
| got, err := blocks.IsExecutionEnabled(st, body) | ||
| require.NoError(t, err) | ||
| require.Equal(t, true, got) | ||
| require.Equal(t, false, got) |
There was a problem hiding this comment.
Same here, why wouldn't this be enabled in capella?
This PR adds Capella spec tests and updates spec tests to the latest alpha release
Pre-req to merging this PR:
ProcessBLSToExecutionChangeschanges inbeacon-chain/core/blocks/withdrawals.gobeacon-chain/core/transition/transition_no_verify_sig.gobeacon-chain/state