Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prysmctl support generating non-phase0 genesis.ssz #11677

Merged
merged 6 commits into from
Nov 23, 2022

Conversation

kasey
Copy link
Contributor

@kasey kasey commented Nov 22, 2022

What type of PR is this?

Feature

What does this PR do? Why is it needed?

Adds a --fork flag to prysmctl testnet generate-genesis to specify other forks beyond phase0:

   --fork value               Name of the BeaconState schema to use in output encoding. [phase0,altair,bellatrix,capella] (default: phase0)

Other notes for review

This was added to help develop changes to allow testnets/e2e to start from a post-merge block. This PR does not unlock that capability, just a small helpful utility broken out into its own PR.

@kasey kasey requested a review from a team as a code owner November 22, 2022 21:38
@kasey kasey requested a review from nisdas November 22, 2022 21:38
@prestonvanloon
Copy link
Member

I ran gazelle, but you have more bazel deps viz issues now.

ERROR: /home/preston/git/prysm/cmd/prysmctl/testnet/BUILD.bazel:3:11: in go_library rule //cmd/prysmctl/testnet:go_default_library: target '//beacon-chain/core/altair:go_default_library' is not visible from target '//cmd/prysmctl/testnet:go_default_library'. Check the visibility declaration of the former target if you think the dependency is legitimate
ERROR: /home/preston/git/prysm/cmd/prysmctl/testnet/BUILD.bazel:3:11: in go_library rule //cmd/prysmctl/testnet:go_default_library: target '//beacon-chain/core/execution:go_default_library' is not visible from target '//cmd/prysmctl/testnet:go_default_library'. Check the visibility declaration of the former target if you think the dependency is legitimate
ERROR: /home/preston/git/prysm/cmd/prysmctl/testnet/BUILD.bazel:3:11: Analysis of target '//cmd/prysmctl/testnet:go_default_library' failed
ERROR: Analysis of target '//cmd/prysmctl:prysmctl' failed; build aborted: 

@prestonvanloon
Copy link
Member

I pushed the fix for gazelle viz changes.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 395e499 into develop Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants