Add minimal withdrawal size #11658
Add minimal withdrawal size #11658
Conversation
| @@ -20,6 +20,7 @@ mainnet = { | |||
| "sync_committee_bits.type": "github.com/prysmaticlabs/go-bitfield.Bitvector512", | |||
| "sync_committee_aggregate_bytes.size": "16", | |||
| "sync_committee_aggregate_bits.type": "github.com/prysmaticlabs/go-bitfield.Bitvector128", | |||
| "withdrawal.size": "16", | |||
There was a problem hiding this comment.
Can this be linked to the minimal preset somehow? We define MAX_WITHDRAWALS_PER_PAYLOAD there, it'd be good if we could automatically change one if we change the other
There was a problem hiding this comment.
Out of my knowledge zone. I'm not sure how to do that. Looking at other variables here, I don't think we've done it before. cc @prestonvanloon for input
There was a problem hiding this comment.
I don't think we can do this with the existing tooling. However, we rarely change this file and all the values are contained in the same file so it may not be worth the trouble of deduplicating. I would approve as is
There was a problem hiding this comment.
The clear separation of minimal and mainnet in the same file makes this deduplication less of an issue as well
There was a problem hiding this comment.
Probably. Someone has to go figure out though
terencechain
added
OK to merge
Ready For Review
|
ptal @prestonvanloon |
Add minimal withdrawal size for ssz. This is needed to pass minimal ssz vector test