Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operations in Capella are as in Bellatrix #11646

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Operations in Capella are as in Bellatrix #11646

merged 2 commits into from
Nov 10, 2022

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Nov 10, 2022

Use the same block operations in Capella as in Bellatrix

@potuz potuz requested a review from a team as a code owner November 10, 2022 00:30
@potuz potuz added Ready For Review A pull request ready for code review OK to merge labels Nov 10, 2022
terencechain
terencechain requested changes Nov 10, 2022
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking a second close took, there's a unit test TestProcessOperationsNoVerifyAttsSigsBellatrix_OK, do you want to add one for Capella too?

@prylabs-bulldozer prylabs-bulldozer bot merged commit 7b63d5c into develop Nov 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the capella_transition branch November 10, 2022 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain approved these changes

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

@james-prysm james-prysm Awaiting requested review from james-prysm james-prysm is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@potuz @terencechain