Implement get_expected_withdrawals #11618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
reviewed
Nov 7, 2022
rkapka
reviewed
Nov 7, 2022
| require.Equal(t, true, v.IsPartiallyWithdrawable(params.BeaconConfig().MaxEffectiveBalance+1)) | ||
| } | ||
|
|
||
| func TestExpectedWithdrawals(t *testing.T) { |
There was a problem hiding this comment.
I would like to see a test case where the validator index wraps around.
rkapka
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
get_expected_withdrawalsas in the specs. It produces the next withdrawals that should be packed in an execution payload.This PR implements some helpers as pure functions when they are already implemented as
ReadOnlyValidatorthese should be removed in a future PR when the implementation is more clear#11619