GetLiveness API endpoint
#11617
Merged
GetLiveness API endpoint
#11617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
rkapka
commented
Nov 4, 2022
| require.NoError(t, err) | ||
| data0 := resp.Data[0] | ||
| data1 := resp.Data[1] | ||
| assert.Equal(t, true, (data0.Index == 0 && !data0.IsLive) || (data0.Index == 1 && !data0.IsLive)) |
There was a problem hiding this comment.
I don't assume any ordering
rkapka
commented
Nov 23, 2022
| @@ -213,7 +213,7 @@ type SpecResponseJson struct { | |||
| Data interface{} `json:"data"` | |||
| } | |||
|
|
|||
| type DutiesRequestJson struct { | |||
| type ValidatorIndicesJson struct { | |||
There was a problem hiding this comment.
I changed the name to be more reusable.
prestonvanloon
requested changes
Nov 23, 2022
| @@ -37,6 +37,7 @@ import ( | |||
| ) | |||
|
|
|||
| var errInvalidValIndex = errors.New("invalid validator index") | |||
| var errParticipation = status.Errorf(codes.Internal, "Could not obtain epoch participation") | |||
There was a problem hiding this comment.
There is no format here, prefer status.Error
Suggested change
| var errParticipation = status.Errorf(codes.Internal, "Could not obtain epoch participation") | |
| var errParticipation = status.Error(codes.Internal, "Could not obtain epoch participation") |
| } | ||
| currEpoch := slots.ToEpoch(headSt.Slot()) | ||
| if req.Epoch > currEpoch { | ||
| return nil, status.Errorf(codes.InvalidArgument, "Requested epoch cannot be in the future") |
There was a problem hiding this comment.
Suggested change
| return nil, status.Errorf(codes.InvalidArgument, "Requested epoch cannot be in the future") | |
| return nil, status.Error(codes.InvalidArgument, "Requested epoch cannot be in the future") |
| @@ -26,4 +27,5 @@ type Server struct { | |||
| SyncCommitteePool synccommittee.Pool | |||
| V1Alpha1Server *v1alpha1validator.Server | |||
| ProposerSlotIndexCache *cache.ProposerPayloadIDsCache | |||
| ReplayerBuilder stategen.ReplayerBuilder | |||
There was a problem hiding this comment.
What is this used for? I don't see it used in this PR.
| @@ -1022,6 +1025,13 @@ func (vs *Server) GetLiveness(ctx context.Context, req *ethpbv2.GetLivenessReque | |||
| Data: make([]*ethpbv2.GetLivenessResponse_Liveness, len(req.Index)), | |||
| } | |||
| for i, vi := range req.Index { | |||
| _, err = st.ValidatorAtIndex(vi) | |||
There was a problem hiding this comment.
This is a bit of an expensive operation. It makes a copy of the validator and if you are iterating over a large request then you might have a noticeable burden on the server.
I think you could simply check that vi is less than len(participation) and return the out of range error if it fails that check
prestonvanloon
previously approved these changes
Nov 23, 2022
rkapka
force-pushed
the
get-liveness-api
branch
from
d6261bf to
46e35e2
Compare
prestonvanloon
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Implements the https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Validator/getLiveness API endpoint.
Other notes for review
I got the idea of using participation bits from @nisdas. We already use them for doppelganger check in Prysm APIs:
prysm/beacon-chain/rpc/prysm/v1alpha1/validator/status.go
Line 101 in 8ade8af