Add 4844 containers to protobuf #11596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
rauljordan
reviewed
Oct 31, 2022
|
|
||
| // Blob contains the data that is to be committed on chain. | ||
| message Blob { | ||
| repeated bytes blob = 1 [(ethereum.eth.ext.ssz_size) = "4096,32"]; |
There was a problem hiding this comment.
Are these going to be different for minimal config? if so we can probably use the dynamic pattern we used for the beacon state and blocks
There was a problem hiding this comment.
Not as of now, we add can add them when minimal config is out
prestonvanloon
requested changes
Oct 31, 2022
| // The block hash of the payload which corresponds to the blobs. | ||
| bytes block_hash = 1 [(ethereum.eth.ext.ssz_size) = "32"]; | ||
| // The KZG commitments of the blobs. | ||
| repeated bytes kzgs = 2 [(ethereum.eth.ext.ssz_size) = "?,48", (ethereum.eth.ext.ssz_max) = "16"]; |
There was a problem hiding this comment.
Does this have to be named kzgs? How about calling it commitments? kzgs is hard type, say, and it's not very idiomatic.
There was a problem hiding this comment.
Yeah. I also like commitments better
There was a problem hiding this comment.
Discussed offline. kzg_commitments is 👑
rkapka
reviewed
Oct 31, 2022
Comment on lines
+159
to
+161
| message Blob { | ||
| repeated bytes blob = 1 [(ethereum.eth.ext.ssz_size) = "4096,32"]; | ||
| } |
There was a problem hiding this comment.
Can we rename blob to data? Blob.Data will be more readable than Blob.Blob.
rkapka
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Spec (EIP4844)
What does this PR do? Why is it needed?
This PR adds the following containers to protobuf for EIP4844:
BlobsBundleSignedBeaconBlockAndBlobsSidecarBlobsSidecarWhich issues(s) does this PR fix?
Part of #11579
Other notes for review