Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unaggregated attestation event #11558

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Handle unaggregated attestation event #11558

merged 2 commits into from
Oct 18, 2022

Conversation

rkapka
Copy link
Contributor

@rkapka rkapka commented Oct 18, 2022

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Currently event handling only works for aggregated attestations. This PR adds necessary code for handling unaggregated attestations. It also improves one of existing tests.

Which issues(s) does this PR fix?

Fixes #11529

@rkapka rkapka added Ready For Review A pull request ready for code review API Api related tasks labels Oct 18, 2022
@rkapka rkapka requested a review from a team as a code owner October 18, 2022 13:37
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit 98b9c9e into develop Oct 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the event-atts branch October 18, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/eth/v1/events head not returning individual attestation data
3 participants