Fix complains and bad test #11555
Merged
Fix complains and bad test #11555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
terencechain
commented
Oct 17, 2022
| @@ -2206,7 +2206,7 @@ type newForkChoicer func() forkchoice.ForkChoicer | |||
| // 2 (and the merge block in this sequence). Block 18 justifies it and Block 19 returns | |||
| // INVALID from NewPayload, with LVH block 12. No head is viable. We check that | |||
| // the node can reboot from this state | |||
| func noViableHead_Reboot(t *testing.T) { | |||
| func TestNoViableHead_Reboot(t *testing.T) { | |||
rauljordan
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix complains for
noViableHead_Reboot->TestNoViableHead_Rebootbeacon-chain/state/stateutil/state_hasher.gowas unused. It looks like it was supposed to remove the native statebeacon-chain/state/testing/getters_block.goprivkey.(*crypto.Secp256k1PrivateKey)did not check for casting error