Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beacon api: propoerly submit blind block #11483

Merged
merged 6 commits into from
Sep 22, 2022

Conversation

terencechain
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

When using beacon API to submit a blind block, it must first go through mev boost/relayer/builder to retrieve the full block. This PR made sure of that. The status duo is to broadcast the blind block, and that's not going to work

Which issues(s) does this PR fix?

Fixes #11477

Other notes for review

N/A

@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review labels Sep 21, 2022
@terencechain terencechain self-assigned this Sep 21, 2022
@terencechain terencechain requested a review from a team as a code owner September 21, 2022 21:40
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have to fix SubmitBlindedBlockSSZ

@terencechain
Copy link
Member Author

We also have to fix SubmitBlindedBlockSSZ

Fixed. thanks!

beacon-chain/rpc/eth/beacon/blocks.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/beacon/blocks.go Outdated Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit 7720d98 into develop Sep 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the rpc-submit-blind-block branch September 22, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

POST /eth/v1/beacon/blinded_blocks Does Not Work
2 participants