Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove protoarray forkchoice #11455

Merged
merged 8 commits into from
Sep 26, 2022
Merged

Remove protoarray forkchoice #11455

merged 8 commits into from
Sep 26, 2022

Conversation

potuz
Copy link
Contributor

@potuz potuz commented Sep 15, 2022

Removes protoarray implementation of forkchoice.

@potuz potuz requested a review from a team as a code owner September 15, 2022 13:26
@terencechain terencechain added the Blocked Blocked by research or external factors label Sep 15, 2022
@potuz potuz force-pushed the remove_protoarray branch 3 times, most recently from 102060a to 66dcc1c Compare September 15, 2022 21:25
@potuz potuz added Ready For Review A pull request ready for code review and removed Blocked Blocked by research or external factors labels Sep 18, 2022
prestonvanloon
prestonvanloon reviewed Sep 23, 2022
View reviewed changes
beacon-chain/blockchain/process_block_helpers.go Outdated Show resolved Hide resolved
beacon-chain/blockchain/chain_info.go Outdated Show resolved Hide resolved
beacon-chain/blockchain/chain_info.go Outdated Show resolved Hide resolved
beacon-chain/forkchoice/doubly-linked-tree/store.go Show resolved Hide resolved
terencechain
terencechain reviewed Sep 25, 2022
View reviewed changes
Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@prylabs-bulldozer prylabs-bulldozer bot merged commit 77fc453 into develop Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the remove_protoarray branch September 26, 2022 14:45
@Inphi Inphi mentioned this pull request Nov 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terencechain terencechain terencechain left review comments

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@nisdas nisdas Awaiting requested review from nisdas nisdas is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@potuz @prestonvanloon @terencechain