Update block arrival histogram values #11424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
beacon-chain/sync/metrics.go
Outdated
| Buckets: []float64{250, 500, 1000, 1500, 2000, 4000, 8000, 16000}, | ||
| Buckets: []float64{100, 500, 1000, 4000, 8000, 12000}, |
There was a problem hiding this comment.
I think you need even more granularity around 500 to 1000ms. Here's a current screenshot from mainnet metrics
There was a problem hiding this comment.
Thanks for the chart! I added 250 and 750 back
There was a problem hiding this comment.
OK great. Are you sure you want to remove 1500 and 2000? That seems like common latency buckets
There was a problem hiding this comment.
No, you are right. I was worried that too many buckets might be bad, but then I realized there's not much downside to it. Thanks for the suggestions!
…labs/prysm into update-block-arrival-histogram
prestonvanloon
requested changes
Sep 12, 2022
…labs/prysm into update-block-arrival-histogram
prestonvanloon
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
Update the current block arrival histogram bucket value to align with our expectations. The best case is for the block to arrive within 100ms, then the block that arrives between 100 - 500ms is likely the second best. Any block to arrives passed one slot will be considered too late and will likely to be orphaned anyway
Which issues(s) does this PR fix?
N/A
Other notes for review
The effort to improve upon the block arrival histogram bucket is we want to begin monitoring block arrival time for reorg against late block proposal. The current bucket is not being looked at much