Remove unused WithTimeout method
#11420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
|
Why is this unused? |
I'm not sure what the original intent was. cc @kasey |
I added it because I was wrapping the underlying http client and thought it would be important to give people access to the underlying timeout setting via an option. I don't remember if I used it at some point or not. I'm fine with removing it and presumably at some point in the lifetime of the library someone else will add it :) |
kasey
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Why is it needed?
Remove unused
WithTimeoutwrapper for HTTP client, I saw this was unused while working on something else and thought to remove it for code healthWhich issues(s) does this PR fix?
N/A
Other notes for review
I'm not sure what the original intention was, maybe we do want to use it? cc @kasey