Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log ready for merge every min #11410

Merged
merged 2 commits into from
Sep 6, 2022
Merged

Log ready for merge every min #11410

merged 2 commits into from
Sep 6, 2022

Conversation

terencechain
Copy link
Member

As previously reproted, logging ready for merge and ttd for every 10s may be too aggressive. This PR changes it to logging every min

@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge UX cosmetic / user experience related labels Sep 6, 2022
@terencechain terencechain requested a review from a team as a code owner September 6, 2022 12:39
@terencechain terencechain self-assigned this Sep 6, 2022
prestonvanloon
prestonvanloon requested changes Sep 6, 2022
View reviewed changes
Copy link
Member

@prestonvanloon prestonvanloon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add defer logTtdTicker.Stop()

@prylabs-bulldozer prylabs-bulldozer bot merged commit 17f3d66 into develop Sep 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the log-ttd-every-min branch September 6, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prestonvanloon prestonvanloon prestonvanloon approved these changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Ready For Review A pull request ready for code review UX cosmetic / user experience related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @prestonvanloon