Fall back to uncached getPaylod if first time outs #11404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potuz
reviewed
Sep 5, 2022
| case err == nil: | ||
| warnIfFeeRecipientDiffers(payload, feeRecipient) | ||
| return payload, nil | ||
| case errors.Is(err, context.Canceled) || errors.Is(err, context.DeadlineExceeded): |
There was a problem hiding this comment.
on context.Canceled we should abort anyway, this is passed by the calling function isn't it?
terencechain
added
Ready For Review
potuz
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated from #11399
If the cached
getPayloadcall to execution client times out, it may be wiser to give it a second try instead of failing block on the spot