Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate downloaded state slot matches header slot #11396

Merged
merged 11 commits into from
Sep 6, 2022

Conversation

terencechain
Copy link
Member

Extra assurance that downloaded state slot matches header slot. We don't want to compute construct block root using skipped slot root. cc @kasey

@terencechain terencechain requested a review from a team as a code owner September 3, 2022 14:42
@terencechain terencechain self-assigned this Sep 3, 2022
@terencechain terencechain added Ready For Review A pull request ready for code review OK to merge labels Sep 4, 2022
Copy link
Contributor

@kasey kasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Terence!

@prylabs-bulldozer prylabs-bulldozer bot merged commit 14a6fe3 into develop Sep 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the check-download-state-slot branch September 6, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants