Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register validator beacon api #11225

Merged
merged 34 commits into from
Aug 17, 2022
Merged

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Aug 15, 2022

What type of PR is this?

Missed Feature

What does this PR do? Why is it needed?
This PR adds the HTTP REST Beacon API endpoint ( spec list here ) for the validator registration API endpoint.

Which issues(s) does this PR fix?

Fixes #11220

@james-prysm james-prysm self-assigned this Aug 15, 2022
@terencechain terencechain requested a review from rkapka August 15, 2022 20:09
@james-prysm james-prysm marked this pull request as ready for review August 15, 2022 20:16
@james-prysm james-prysm requested a review from a team as a code owner August 15, 2022 20:16
@james-prysm james-prysm added Bug Something isn't working API Api related tasks Builder PR or issue that supports builder related work labels Aug 15, 2022
Copy link
Contributor

@rkapka rkapka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs API Middleware setup

beacon-chain/rpc/eth/validator/validator.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/validator/validator.go Outdated Show resolved Hide resolved
beacon-chain/rpc/eth/validator/validator.go Outdated Show resolved Hide resolved
@prylabs-bulldozer prylabs-bulldozer bot merged commit 2377d6d into develop Aug 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the register-validator-beacon-api branch August 17, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Api related tasks Bug Something isn't working Builder PR or issue that supports builder related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /eth/v1/validator/register_validator to Beacon API
3 participants