Tests for builder service #11214
Merged
Tests for builder service #11214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
added
Ready For Review
terencechain
previously approved these changes
Aug 12, 2022
| @@ -295,3 +307,12 @@ func non200Err(response *http.Response) error { | |||
| return errors.Wrap(ErrNotOK, errMessage.Message) | |||
| } | |||
| } | |||
|
|
|||
| func covertEndPoint(ep string) network.Endpoint { | |||
There was a problem hiding this comment.
This would be useful as a general helper in a common location, we do something like this in execution service as well. Another PR will be great for this
This reverts commit c4c1016cb597b9340d1c81ab3816e037a6b97f9e.
terencechain
previously approved these changes
Aug 12, 2022
|
Removing |
# Conflicts: # api/client/builder/client.go # beacon-chain/builder/option.go # beacon-chain/builder/service.go
|
Tests fail @rkapka |
# Conflicts: # beacon-chain/builder/service.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Testing
What does this PR do? Why is it needed?
Adds tests to non-trivial functions of
beacon-chain/builder/service.go. To make the service testable, a newBuilderClientinterface was created and the tight coupling between a concrete implementation of the builder and the service was removed. Currently a new builder is instantiated directly in the service's constructor. This PR shifts dependencies and makes the builder configurable via an option.