Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct fork and genesis root to verify bid #11176

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Use correct fork and genesis root to verify bid #11176

merged 1 commit into from
Aug 5, 2022

Conversation

terencechain
Copy link
Member

This PR fixes signed bid validation to use the correct fork and genesis root. Source: https://github.com/ethereum/builder-specs/blob/main/specs/builder.md#signing

@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review Priority: High High priority item OK to merge labels Aug 5, 2022
@terencechain terencechain self-assigned this Aug 5, 2022
@terencechain terencechain requested a review from a team as a code owner August 5, 2022 18:39
james-prysm
james-prysm approved these changes Aug 5, 2022
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing this because similar to registration. use nil instead of current fork version.

@prylabs-bulldozer prylabs-bulldozer bot merged commit 4e225fc into develop Aug 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the can-validate-builder-bid branch August 5, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@rauljordan rauljordan Awaiting requested review from rauljordan rauljordan is a code owner automatically assigned from prysmaticlabs/core-team

@rkapka rkapka Awaiting requested review from rkapka rkapka is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Bug Something isn't working Priority: High High priority item Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @james-prysm