Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Goodbye Codes In Prysm #11168

Merged
merged 5 commits into from
Aug 4, 2022
Merged

Fix Goodbye Codes In Prysm #11168

merged 5 commits into from
Aug 4, 2022

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Aug 4, 2022

What type of PR is this?

Bug Fix

What does this PR do? Why is it needed?

  • Prysm had goodbye codes which deviated from the spec, this PR fixes it and adds in a regression test.

Which issues(s) does this PR fix?

N.A

Other notes for review

@nisdas nisdas added Ready For Review A pull request ready for code review Networking P2P related items OK to merge labels Aug 4, 2022
@nisdas nisdas requested a review from a team as a code owner August 4, 2022 13:04
rauljordan
rauljordan previously approved these changes Aug 4, 2022
View reviewed changes
@prylabs-bulldozer prylabs-bulldozer bot merged commit e169ce9 into develop Aug 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the fixGoodbyeCodes branch August 4, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauljordan rauljordan rauljordan approved these changes

@kasey kasey Awaiting requested review from kasey kasey is a code owner automatically assigned from prysmaticlabs/core-team

@terencechain terencechain Awaiting requested review from terencechain terencechain is a code owner automatically assigned from prysmaticlabs/core-team

@symbolpunk symbolpunk Awaiting requested review from symbolpunk symbolpunk is a code owner automatically assigned from prysmaticlabs/core-team

Assignees
No one assigned
Labels
Networking P2P related items Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nisdas @rauljordan