Capella beacon state #11141
+4,109
−921
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package state_native | ||
|
|
||
| import ( | ||
| types "github.com/prysmaticlabs/prysm/consensus-types/primitives" | ||
| enginev1 "github.com/prysmaticlabs/prysm/proto/engine/v1" | ||
| ethpb "github.com/prysmaticlabs/prysm/proto/prysm/v1alpha1" | ||
| "github.com/prysmaticlabs/prysm/runtime/version" | ||
| ) | ||
|
|
||
| // WithdrawalQueue returns the list of pending withdrawals. | ||
| func (b *BeaconState) WithdrawalQueue() ([]*enginev1.Withdrawal, error) { | ||
| if b.version < version.Capella { | ||
| return nil, errNotSupported("WithdrawalQueue", b.version) | ||
| } | ||
|
|
||
| b.lock.RLock() | ||
| defer b.lock.RUnlock() | ||
|
|
||
| return b.withdrawalQueueVal(), nil | ||
| } | ||
|
|
||
| func (b *BeaconState) withdrawalQueueVal() []*enginev1.Withdrawal { | ||
| return ethpb.CopyWithdrawalSlice(b.withdrawalQueue) | ||
| } | ||
|
|
||
| // NextWithdrawalIndex returns the index that will be assigned to the next withdrawal. | ||
| func (b *BeaconState) NextWithdrawalIndex() (uint64, error) { | ||
| if b.version < version.Capella { | ||
| return 0, errNotSupported("NextWithdrawalIndex", b.version) | ||
| } | ||
|
|
||
| b.lock.RLock() | ||
|
There was a problem hiding this comment. do we want a lock to read the version? There was a problem hiding this comment. Version? This is There was a problem hiding this comment. I think @potuz refers to |
||
| defer b.lock.RUnlock() | ||
|
|
||
| return b.nextWithdrawalIndex, nil | ||
| } | ||
|
|
||
| // NextPartialWithdrawalValidatorIndex returns the index of the validator which is | ||
| // next in line for a partial withdrawal. | ||
| func (b *BeaconState) NextPartialWithdrawalValidatorIndex() (types.ValidatorIndex, error) { | ||
| if b.version < version.Capella { | ||
| return 0, errNotSupported("NextPartialWithdrawalValidatorIndex", b.version) | ||
| } | ||
|
|
||
| b.lock.RLock() | ||
| defer b.lock.RUnlock() | ||
|
|
||
| return b.nextPartialWithdrawalValidatorIndex, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This case switch is a good candidate for simplification using generics since all cases are the same function based on pbState.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this was my impression too. But I didn't want to refactor existing code in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't even a need for generics if we can just pass in fastssz.Marshaler as an interface (beacon state satisfies this)