Rename web3 provider flag to execution endpoint #11133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // ExecutionEngineEndpoint provides an HTTP access endpoint to connect to an execution client on the execution layer | ||
| ExecutionEngineEndpoint = &cli.StringFlag{ | ||
| Name: "execution-endpoint", | ||
| Usage: "An execution client http endpoint. Can contain auth header as well in the format", |
There was a problem hiding this comment.
If you add an alias for the old flag name, then this isn't really a breaking change.
There was a problem hiding this comment.
Good pt. I added the alias but updated the default port to 8551 since 8545 is no longer relevant post merge. Due to port changes, it's breaking now
terencechain
commented
Aug 11, 2022
cmd/beacon-chain/flags/base.go
Outdated
| Name: "execution-endpoint", | ||
| Usage: "An execution client http endpoint. Can contain auth header as well in the format", | ||
| Value: "http://localhost:8551", | ||
| Aliases: []string{"http-web3provider"}, |
There was a problem hiding this comment.
I'm tempted to add this alias, so it's not a complete breaker, anyone has an opinion here?
terencechain
added
Ready For Review
rauljordan
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
--http-web3providerto--execution-endpoint. Change default default port to 8551