Validate builder signature for Bid #11124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
nisdas
reviewed
Jul 28, 2022
| @@ -117,6 +118,10 @@ func (vs *Server) getPayloadHeader(ctx context.Context, slot types.Slot, idx typ | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if err := vs.validateBuilderSignature(bid); err != nil { | |||
There was a problem hiding this comment.
How does this work if we dont run with a builder ?
There was a problem hiding this comment.
getAndBuildHeaderBlock and getPayloadHeader won't get called becausevs.BlockBuilder.Configured() will return false. I also can be super defensive and check vs.BlockBuilder.Configured() again before GetHeader and return an error if it's false. (That's something you will like?)
nisdas
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11111
Validates builder's signature in
SignedBid. If the signature is invalid, we default back to the local EE