Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing gaslimit to validator registration #10992

Merged
merged 10 commits into from
Jul 6, 2022

Conversation

james-prysm
Copy link
Contributor

@james-prysm james-prysm commented Jul 5, 2022

What type of PR is this?

Feature

related to #10593
What does this PR do? Why is it needed?
This feature brings a way to define validator registration ( builder API) usage by validator public key in the proposer settings file and is intended to mirror teku. if the validator registration portion is filled then it will be used to call the submit validator registration API.

  • This introduces a breaking change for individuals who are using the gas limit feature. : this will wrap gas limit with another object that includes an optional enable field.

  • update proposer settings file to include a validator registration object instead of just gas_limit

{
  "proposer_config": {
    "0xa057816155ad77931185101128655c0191bd0214c201ca48ed887f6c4c6adf334070efcd75140eada5ac83a92506dd7a": {
      "fee_recipient": "0x50155530FCE8a85ec7055A5F8b2bE214B3DaeFd3",
      "validator_registration": {
        "enable": true,
        "gas_limit": 30000000
      }
    },
   
  "default_config": {
    "fee_recipient": "0x6e35733c5af9B61374A128e6F85f553aF09ff89A",
    "validator_registration": {
      "enable": true,
      "gas_limit": 30000000
    }
  }
}

@james-prysm james-prysm self-assigned this Jul 6, 2022
@james-prysm james-prysm added Builder PR or issue that supports builder related work UX cosmetic / user experience related labels Jul 6, 2022
@james-prysm james-prysm marked this pull request as ready for review July 6, 2022 12:56
@james-prysm james-prysm requested a review from a team as a code owner July 6, 2022 12:56
@james-prysm james-prysm requested a review from terencechain July 6, 2022 14:03
terencechain
terencechain previously approved these changes Jul 6, 2022
cmd/validator/flags/flags.go Outdated Show resolved Hide resolved
rauljordan
rauljordan previously approved these changes Jul 6, 2022
@rauljordan rauljordan dismissed stale reviews from terencechain and themself via 3b908d2 July 6, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builder PR or issue that supports builder related work UX cosmetic / user experience related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants