Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register builder service #10924

Merged
merged 3 commits into from
Jun 23, 2022
Merged

Register builder service #10924

merged 3 commits into from
Jun 23, 2022

Conversation

terencechain
Copy link
Member

Can register builder service through the node.go. I had to change Status(ctx context.Context) to Status() to satisfy service interface

@terencechain terencechain added Ready For Review A pull request ready for code review Builder PR or issue that supports builder related work labels Jun 23, 2022
@terencechain terencechain self-assigned this Jun 23, 2022
@terencechain terencechain marked this pull request as ready for review June 23, 2022 15:53
@terencechain terencechain requested a review from a team as a code owner June 23, 2022 15:53
james-prysm
james-prysm approved these changes Jun 23, 2022
View reviewed changes
Copy link
Contributor

@james-prysm james-prysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@terencechain terencechain merged commit 88becdc into develop Jun 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the register-builder-service branch June 23, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-prysm james-prysm james-prysm approved these changes

@saolyn saolyn Awaiting requested review from saolyn saolyn is a code owner automatically assigned from prysmaticlabs/core-team

@potuz potuz Awaiting requested review from potuz potuz is a code owner automatically assigned from prysmaticlabs/core-team

Assignees

@terencechain terencechain

Labels
Builder PR or issue that supports builder related work Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terencechain @james-prysm