Remove Execution Client Fallback and Make Providing an Execution Client Required #10921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
changed the title
nisdas
reviewed
Aug 15, 2022
| @@ -105,46 +104,16 @@ func (s *Service) retryExecutionClientConnection(ctx context.Context, err error) | |||
| // is ready to serve we connect to it again. This method is only | |||
| // relevant if we are on our backup endpoint. | |||
| func (s *Service) checkDefaultEndpoint(ctx context.Context) { | |||
There was a problem hiding this comment.
We only have 1 endpoint now, this will basically cause prysm to keep on creating new connections to our execution node. This method should be removed since it serves no purpose with 0 fallback endpoints.
nisdas
previously approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10588.
This PR removes all things related to execution client fallbacks, which will not be supported starting in v3. This also makes providing a non-empty execution client endpoint a requirement to run a node. Prysm nodes have a default value of localhost:8545 at this time