Network/Hardware: Upgrade to latest STM32F4xx_HAL_Driver and fix network autonegotiation issues with LAN8742 #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danopernis
reviewed
Dec 13, 2024
|
Hello, is possible to test this without breaking the appendix on the mainboard? i'm linux admin so i can test networking properly i think. What about some signed closed alpha FW for testers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up PR to #4171.
This upgrades the STM32F4xx_HAL_Driver to the latest commit 8f20a7dfd0b5902e1a5796be78ed2ceddd342085 and includes needed fixes for adapting the upgrade.
Furthermore, this addresses an issue with incorrect network autonegotiation due to incorrect register usage (STM32F4xx reference network registers were used, however LAN8742 registers were needed). Code has been adapted to xBuddy from STM LAN8742 SDK example code.
The firmware has been tested on two Prusa xBuddy MK4 boards. DHCP functions as well full-duplex LAN functions were confirmed to work correctly by two developers.