Android isAvailable method checks Custom Tab support #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdnichollsc
reviewed
Nov 7, 2019
|
hi, any updates? |
|
Let me know if it works for AndroidX 🙂 |
ghost
mentioned this pull request
|
any plan for merging this? |
|
@ssuchanowski do you know if it works for AndroidX too? |
|
Hadn't tested it but it seems like this service name is mentioned here https://developer.android.com/reference/androidx/browser/customtabs/CustomTabsService which is an android x documentation. |
|
Ok, let me check this weekend, thanks for confirm! |
|
hey @jdnichollsc did you have time to take a look? There is also another PR (#160) with a simple fix. |
|
@ssuchanowski sorry mate, I was so busy, let me check at night :) |
|
No idea |
|
Just double-checked, it's working properly! Fixed the merge conflicts as well. |
phuongwd
pushed a commit
to phuongwd/react-native-inappbrowser
that referenced
this pull request
Jul 31, 2020
Android isAvailable method checks Custom Tab support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android's isAvailable method now checks if any installed browser supports Custom Tabs.
This solves issue #91.