chore(RLS): Improve policy comparison #6064
Draft
+9
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When an RLS policy is applied to a query, the conditions specified in the policy are evaluated for each row that the query touches. In queries affecting thousands of rows, this behavior can drastically reduce query performance, as the overhead of executing these functions adds up quickly. -- https://supabase.com/docs/guides/database/database-advisors?queryGroups=lint&lint=0003_auth_rls_initplan#the-performance-issue
Description
Improve Postgres Row Level Security policies:
CASE
since it is not needed, a comparison withnull
returnsfalse
, so callingcurrent_setting('setting', True)
is more than enough.current_setting
in a subquery to be executed in anInitPlan
which will be executed just once and then the result will be cached for the rest of the rows.TODO
Checklist
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.