Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): GitHub integration PoC #5787

Draft
wants to merge 31 commits into
base: master
Choose a base branch
from
Draft

feat(github): GitHub integration PoC #5787

wants to merge 31 commits into from

Conversation

HugoPBrito
Copy link
Member

Context

Prowler aims to integrate GitHub as a provider to implement checks and ensure compliance standards are met.

Description

I've been working to mirror the structure used by other providers for GitHub, aiming to create a comprehensive PoC.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 89.82%. Comparing base (a5f5967) to head (b815eeb).

Files with missing lines Patch % Lines
prowler/lib/outputs/finding.py 0.00% 7 Missing ⚠️
prowler/lib/outputs/html/html.py 28.57% 5 Missing ⚠️
prowler/__main__.py 0.00% 3 Missing ⚠️
prowler/lib/check/models.py 62.50% 3 Missing ⚠️
prowler/lib/outputs/summary_table.py 0.00% 3 Missing ⚠️
prowler/providers/common/provider.py 0.00% 2 Missing ⚠️
prowler/lib/outputs/outputs.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5787      +/-   ##
==========================================
- Coverage   89.88%   89.82%   -0.06%     
==========================================
  Files        1133     1133              
  Lines       35313    35345      +32     
==========================================
+ Hits        31741    31750       +9     
- Misses       3572     3595      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the compliance Issues/PRs related with the Compliance Frameworks label Nov 18, 2024
@github-actions github-actions bot added the output/html Issues/PRs related with the HTML output format label Nov 19, 2024
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Nov 20, 2024
@HugoPBrito HugoPBrito added provider/github and removed provider/gcp Issues/PRs related with the Google Cloud Platform provider labels Nov 25, 2024
Removed deprecated user-passwd login and replaced it with github app
@github-actions github-actions bot added the provider/gcp Issues/PRs related with the Google Cloud Platform provider label Nov 25, 2024
Removed CIS compliance from check metadata
@MrCloudSec
Copy link
Member

MrCloudSec commented Nov 26, 2024

  1. Remove the flags that look into environment variables, and instead, if no flag is passed in the GitHub provider, look for any existing environment variable.
  2. Enforce flags --github-app-key and --github-app-id to be present when any of them are passed.
  3. Update print_credentials function with information for each type of authentication.
  4. Add a test for each auth method in the provider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance Issues/PRs related with the Compliance Frameworks output/html Issues/PRs related with the HTML output format provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/github
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants