Update ibc-go to v6.1 #1278
Merged
Update ibc-go to v6.1 #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 20, 2022 11:19
… longer exposed. Need to still update app.go.
… to have new location of DefaultGenesis. Added memo to marker ibc transfer.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
+ Coverage 58.62% 58.64% +0.02%
==========================================
Files 206 206
Lines 25478 25486 +8
==========================================
+ Hits 14937 14947 +10
+ Misses 9434 9429 -5
- Partials 1107 1110 +3
|
nullpointer0x00
requested changes
Dec 29, 2022
llama-del-rey
previously approved these changes
Jan 5, 2023
Taztingo
dismissed stale reviews from llama-del-rey and nullpointer0x00
via
eef9322
|
@Taztingo a question on this please.. Is there a reason for keeping |
llama-del-rey
approved these changes
Jan 6, 2023
Initially, that's what I tried. However, there is validation done that prevents us from sending the marker. We need to bypass one of those checks so I had to call SendTransfer directly. |
nullpointer0x00
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates ibc-go/v5 to ibc-go/v6. This should only be merged in after #1265 has been merged in as we use cosmos 46.7. This is still using our custom provenance/ibc-go branch, but hopefully in the future we can remove it. In order to use ibc-go/v6 we had to update our custom provenance/ibc-go branch and provenance/wasmd.
closes: #1273
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes