Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing java load #19001

Closed
wants to merge 2 commits into from
Closed

Conversation

ted-xie
Copy link
Contributor

@ted-xie ted-xie commented Oct 25, 2024

No description provided.

@ted-xie ted-xie requested a review from a team as a code owner October 25, 2024 18:39
@ted-xie ted-xie requested review from zhangskz and removed request for a team October 25, 2024 18:39
@shaod2 shaod2 added the java label Oct 28, 2024
@zhangskz
Copy link
Member

We typically land changes to our release branches (e.g. 29.x) as cherry-picks after first landing in main. Ideally, this should be sent to us as a CL internally to be synced to open-source, then cherry-picked back to 29.x.

Adding "safe for tests" in the interim for test results.

Can you also provide more details in the change description why this is needed / what issues you may have hit?

@zhangskz zhangskz added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 28, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 28, 2024
@ted-xie
Copy link
Contributor Author

ted-xie commented Oct 28, 2024

I'm landing this upstream and will cherry-pick into 29.x branch once the main branch commit lands.

@ted-xie ted-xie closed this Oct 28, 2024
@ted-xie
Copy link
Contributor Author

ted-xie commented Oct 28, 2024

This has been replaced by #19016.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants