Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not throw deprecated warning on field getters for default values #17788

Closed
wants to merge 8 commits into from
Closed

fix: do not throw deprecated warning on field getters for default values #17788

wants to merge 8 commits into from

Conversation

bshaffer
Copy link
Contributor

fixes #13428

Wraps deprecated field getters in a conditional to see if the value has been set before throwing the warning. This is because this method is used internally, so users can get deprecated warnings even when they are not using the field.

@bshaffer bshaffer requested a review from a team as a code owner August 12, 2024 18:37
@bshaffer bshaffer requested review from anandolee and removed request for a team August 12, 2024 18:37
This was referenced Aug 12, 2024
Closed
Closed
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 12, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 12, 2024
@bshaffer bshaffer requested a review from googleberg August 12, 2024 18:38
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 12, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 12, 2024
bshaffer
bshaffer commented Aug 12, 2024
View reviewed changes
Copy link
Contributor Author

@bshaffer bshaffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's enough complexity around getting the field to even check if it's default... for instance, $this->readOneof should be called instead of the property name for "OneOf fields", and $this->readWrapperValue should be called for "wrapped" fields

src/google/protobuf/compiler/php/php_generator.cc Show resolved Hide resolved
src/google/protobuf/compiler/php/php_generator.cc Show resolved Hide resolved
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 13, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 13, 2024
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 13, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 13, 2024
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 20, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 20, 2024
@bshaffer bshaffer added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 20, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkruskal-google mkruskal-google mkruskal-google approved these changes

@anandolee anandolee Awaiting requested review from anandolee anandolee is a code owner automatically assigned from protocolbuffers/protobuf-php

@googleberg googleberg Awaiting requested review from googleberg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PHP: Deprecation message for "return_immediately" is thrown which is impossible to fix
2 participants
@bshaffer @mkruskal-google