Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed specific MSVC settings when installing #17285

Closed
wants to merge 1 commit into from

Conversation

EduMenges
Copy link
Contributor

@EduMenges EduMenges commented Jun 29, 2024

When installing protobuf, it creates a different directory for CMake's config files when compiling with MSVC.

gRPC build on Windows
protobuf-on-windows

gRPC build on Linux and macOS
protobuf-on-linux

This is problematic because it requires conditionally setting its protobuf_DIR for different platforms:

if(MSVC)
    set(Protobuf_DIR "${PROTOBUF_PREFIX}/cmake")
else()
    set(Protobuf_DIR "${PROTOBUF_PREFIX}/lib/cmake/protobuf")
endif()

The original commit that made this based its choice on CMake's version 3.4, which not only is deprecated but is also based on a CMake version less than the one defined in the master file. Since then, CMake changed its behaviour, making this distinction unnecessary.

@EduMenges EduMenges requested a review from a team as a code owner June 29, 2024 12:02
@EduMenges EduMenges requested review from haberman and removed request for a team June 29, 2024 12:02
@haberman haberman requested a review from mkruskal-google July 8, 2024 18:47
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@mkruskal-google mkruskal-google added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Jul 8, 2024
@copybara-service copybara-service bot closed this in 770090e Jul 9, 2024
copybara-service bot pushed a commit to grpc/grpc that referenced this pull request Sep 24, 2024
Regular protobuf upgrade from 27.2 to 28.1 along with the required change to accommodate protocolbuffers/protobuf#17285

Closes #37682

PiperOrigin-RevId: 678428936
sourabhsinghs pushed a commit to sourabhsinghs/grpc that referenced this pull request Sep 26, 2024
Regular protobuf upgrade from 27.2 to 28.1 along with the required change to accommodate protocolbuffers/protobuf#17285

Closes grpc#37682

PiperOrigin-RevId: 678428936
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Nov 25, 2024
Regular protobuf upgrade from 27.2 to 28.1 along with the required change to accommodate protocolbuffers/protobuf#17285

Closes grpc#37682

PiperOrigin-RevId: 678428936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants